ADFFS 2.80 public beta

[JonAbbott]

ADFFS 2.80u in the OP and available for testers via PackMan. A few game packages have also been updated to resolve Page Zero access bugs.

Blaston [UCS]
Gives error
IRQv: E9EFDFF6
ADFFS Exception: ADFF5009 Instruction not implemented.
Only seems to affect the UCS version, the standard Blaston works without issue

I've fixed the initial issue, but there's another problem which is causing the game to get stuck in a loop. I'll continue to investigate.

This is down to an issue with the !Run, I'll update the package soon.

Bloodsport
Gives error
IRQv: E9EFDFF6
ADFFS Exception: ADFF5016 Modifying hardware vectors

I'm seeing the same, so will investigate. It's triggering a Page Zero access in FileCore so is going to leave the machine in a dodgy state.

This has turned out to be an issue in the !Run, I'll update the package soon.

Casino
All of the games load to the system tray, after showing the disk error, but don't seem to allow you to do anything

It's the disc protection failing, I'll update the package to resolve soon.

Champions
MUFC - Seems to load ok, but when trying to start a game, I just get a black screen and the music continues to play
Boxing Manager - Seems to work fine
Leaderboard - Seems to work fine, although runs way too fast
Squash - Can't move the cursor once the game loads. Pressing ctrl-shift-f12 does return you to the desktop (NB the original version of this works fine, this issue seems to only manifest in this champions version)

MUFC is asking for disc 2 - its a known issue with this version. I'll see if I can modify its code to resolve.
Leaderboard - I'll see if there's a way to slow it down
Squash - it appears to be stuck in a loop waiting for an event to trigger, I'll investigate further.

EDIT: Squash's issue appears to be related to Joystick support as RMKill'ing USBJoystick gets it working, I'll continue to investigate.

Chocks Away
Loads title screen, but then shows a > at the top of the screen and doesn't do anything else

Chopper Force
Doesn't load game, just freezes with a white line at top left of screen

These are both due to a reentrancy issue in the ADFFS Event handler. I'll fix for the next build.
This issue will affect most Fourth Dimension titles.

Command Ship
IRQv: E9EFEFF6
ADFFS Exception: ADFF5016 Modifying hardware Vectors

It's a Page Zero access bug, and there's another a bit further on in the code. I'll figure out a fix.

EDIT: After further investigation, I think this is down to a bug in RISC OS which I've raised here. I've implemented a workaround in the next build of ADFFS.

Cyberzone
Game loads ok, then shows a lot of > in bottom window and doesn't let you type or do anything. Ctrl-Shift-F12 takes you back to desktop though, so this could be me not knowing what I am doing

It's a turn based adventure. Type HELP for the commands and move with the Cursor keys.

Cyborg
Both games work fine, however on Cyborg the Adventure, pressing ctrl-shift-f12 causes an Internal error: abort on data transfer at &FC1ABCA0570 error

I couldn't reproduce that issue, but it does mess with the Wimp mode which might be triggering the Abort you're seeing. I'll investigate further.

Jinxter
Game loads ok, but then locks up at the beginning when it tries to show the first picture. I recall having this issue on my original copy of Jinxter, but cant remember how I resolved it.

I couldn't reproduce this issue, could you try copying !Jinxter to RAM: and then run it. Some of the earlier Magnetic Scrolls adventures can't handle file path lengths over ~70 chars. I've not put the package of Wonderland up for this reason.

[JonAbbott]

ADFS 2.80w in the OP and and PackMan for testers. Various bug fixes in ADFFS and updated game packages as noted in my previous post.

[Idge]

Thanks Jon, I have tested again with the latest beta. See notes below

Casino

It's the disc protection failing, I'll update the package to resolve soon.

This now works correctly

Chocks Away

Chopper Force

These are both due to a reentrancy issue in the ADFFS Event handler. I'll fix for the next build.
This issue will affect most Fourth Dimension titles.

These both now work correctly

Command Ship

It's a Page Zero access bug, and there's another a bit further on in the code. I'll figure out a fix.

EDIT: After further investigation, I think this is down to a bug in RISC OS which I've raised here. I've implemented a workaround in the next build of ADFFS.

This now works correctly

Cyberzone

It's a turn based adventure. Type HELP for the commands and move with the Cursor keys.

So it turns out you can only type in CAPS which was why I thought it was not working. All working fine now

Jinxter

I couldn't reproduce this issue, could you try copying !Jinxter to RAM: and then run it. Some of the earlier Magnetic Scrolls adventures can't handle file path lengths over ~70 chars. I've not put the package of Wonderland up for this reason.

This is now working fine without copying to the RAM Disk, so may have just been a random lock up last time.

[JonAbbott]

Champions
MUFC - Seems to load ok, but when trying to start a game, I just get a black screen and the music continues to play

MUFC is asking for disc 2 - its a known issue with this version. I'll see if I can modify its code to resolve.

This should be fixed with the next ADFFS build. I've slowed down the animations on the menu and it now displays the disc swap prompts.

Champions
Leaderboard - Seems to work fine, although runs way too fast

Now that I've checked, I've already added all the code to slow it down to match an A310. I'll make it 1/3 of the speed in the next ADFFS build.

[Idge]

Some more testing tonight, all on the latest beta. I suspect a lot of the ones where the lockups happen on ctrl-shift-f12 are because they load to the System tray so interact with the WIMP.

Demons Lair [SA]
Game works fine, but ctrl-shift-f12 locks up the pi

Dominate
Seems to work fine but slight graphical glitch on left side of screen when playing wipeout

Dreadnoughts
Game works fine, but ctrl-shift-f12 causes Internal Error: abort on data transfer at &FC1ABC9C 570

E-Type II
Loads game ok, but pressing ctrl-shift-f12 causes lockup.

Elite
Game works fine, but pressing ctrl-shift-f12 causes lockup

Enter The Realm
The music sounds wrong when starting the game I think. I tested my original to see what it should sound like to be sure
There is also graphical corruption on the right side of the screen, but is still playable

Enter The Realm [SA]
Music also sounds off on this version when starting game, but this one doesn't have the graphical corruption on right of screen

Enthar7
Loads the title screen and asks to press space to play, but locks up pi when doing so

Fervour
Game works fine, but ctrl-shift-f12 locks up pi

Fireball 1 & 2
Fireball - game loads, but when you press space to play it gives error:
OS Claim 10 @ 0000C748 R12=00000000
ADFFS Exception: ADFF5016 Modifying hardware vectors
Fireball 2 - Mostly fine, but has the occasional glitch in the music

Foray
Game works fine, but ctrl-shift-f12 locks up pi

Formula Fun
Game loads fine, but once you start game you get a flashing cursor in the middle of the screen and game locks up. Ctrl-Shift-F12 locks the pi

Frak
Just goes to a black screen after frak logo shows up and locks up pi

Freddys Folly
Game works fine, but ctrl-shift-f12 locks up pi

Global Effect
Asks for icons from manual for the copy protection. Tried random ones, but this bounced me back to the desktop

Gods [RPC]
Everything runs really slowly, not sure if this expected or not

Guile
Game works fine, but ctrl-shift-f12 causes internal error: abort on data transfer at &FC1ABCA0 570

[JonAbbott]

Demons Lair [SA]
Game works fine, but ctrl-shift-f12 locks up the pi

Elite
Game works fine, but pressing ctrl-shift-f12 causes lockup

E-Type II
Loads game ok, but pressing ctrl-shift-f12 causes lockup

Fervour
Game works fine, but ctrl-shift-f12 locks up pi

Foray
Game works fine, but ctrl-shift-f12 locks up pi

These are WIMP based, you'll need to quit them legally or the Wimp will crash if it suddenly loses a task.

Dominate
Seems to work fine but slight graphical glitch on left side of screen when playing wipeout

It's corruption on the original floppy, I'm looking out for another copy to image.

Dreadnoughts
Game works fine, but ctrl-shift-f12 causes Internal Error: abort on data transfer at &FC1ABC9C 570

This is another that messes with the Wimp mode, which I suspect is causing the crash. I've also noticed it crashes if you say NO to "Are you playing the Seatrial scenario" and then press ENTER

Enter The Realm
The music sounds wrong when starting the game I think. I tested my original to see what it should sound like to be sure
There is also graphical corruption on the right side of the screen, but is still playable

Enter The Realm [SA]
Music also sounds off on this version when starting game, but this one doesn't have the graphical corruption on right of screen

I wasn't aware of the music issue, so will check that against a physical machine. I am aware of the graphical glitch, which I think is a timing issue around when the game sets HDER. I've yet to pin it down though.

EDIT: The music problem is an issue with the load order in the Boot script/!Run, I'll upload a revised package for the SA version soon and will fix both Boot scripts in the next ADFFS build. There's also a lock-up when terminating the original release via CTRL-SHIFT-F12, which will be fixed as well.

EDIT2: For progress on the screen corruption issue, see this thread.

Enthar7
Loads the title screen and asks to press space to play, but locks up pi when doing so

This one has been problematic in the past as it runs under a poorly written 6502 emulator that hacks into RISC OS. I'll investigate

EDIT: This looks like the machine is hard locking when OS_ReadC is called, but I'm struggling to understand why. It works under 2.74 and fails under the first build of 2.80, which tells me it's the initial JIT changes that are the root cause, but I don't see how they impact OS_ReadC. My initial thought was IRQ related, but IRQ's are enabled on entry to OS_ReadC and there are no event claims by the 6502 emulator.

EDIT2: It's not OS_ReadC, but code called after. Unfortunately, its really hard to trace the code path due to the hard-lock so I need to figure out a way of code tracing.

Fireball 1 & 2
Fireball - game loads, but when you press space to play it gives error:
OS Claim 10 @ 0000C748 R12=00000000
ADFFS Exception: ADFF5016 Modifying hardware vectors
Fireball 2 - Mostly fine, but has the occasional glitch in the music

Fireball - Looks like a bug in the code to me as it doesn't look like a Null dereference, will investigate

Fireball 2 - I've left it playing and didn't notice anything obvious with the music. Could you describe the issue and at what point it occurs?

Formula Fun
Game loads fine, but once you start game you get a flashing cursor in the middle of the screen and game locks up. Ctrl-Shift-F12 locks the pi

EDIT: I believe this is working, although the cursor should be off and it should not hang on CTRL-SHIFT-F12. Press Up Arrow to accelerate, Left/Right to steer and Down to break.

Frak
Just goes to a black screen after frak logo shows up and locks up pi

I'm seeing the same issue, will investigate

Freddys Folly
Game works fine, but ctrl-shift-f12 locks up pi

This game is native and doesn't run on the JIT. I suspect you were sitting on the screen of text, where pressing the Left Arrow will bring your canon out. You'll need to reboot the Pi as you can't exit the game.

Global Effect
Asks for icons from manual for the copy protection. Tried random ones, but this bounced me back to the desktop

See the page on Manual based protection, pressing SPACE will bypass it. This one is WIMP based, so don't use CTRL-SHIFT-F12 to terminate it.

Gods [RPC]
Everything runs really slowly, not sure if this expected or not

Yes, it seems to be running at half speed. The game self regulates, so I suspect a bug in the code. I'll investigate
EDIT: Its expecting a 100Hz monitor refresh rate. I'll update the package soon to support 50Hz

Guile
Game works fine, but ctrl-shift-f12 causes internal error: abort on data transfer at &FC1ABCA0 570

Another game that appears to be messing with the WIMP mode. I'm not sure why they're all causing a crash on your machine.

Could you please press F12 and type *WHERE after the crash, to see which ROM Module the crash is occurring in.

[Idge]

Fireball 1 & 2

Fireball - Looks like a bug in the code to me as it doesn't look like a Null dereference, will investigate

Fireball 2 - I've left it playing and didn't notice anything obvious with the music. Could you describe the issue and at what point it occurs?

The music starts off fine, but after it has been playing for a while, it starts having glitches with some of the instruments. I just tested it and timed it with a stop watch from when the music starts and it starts going wrong after 01:32
EDIT: I have now updated my Pi to the latest stable Riscos rom and wiped it and set it all up from scratch and this no longer happens. I have left it playing for a while and it all sounds correct now

Formula Fun

EDIT: I believe this is working, although the cursor should be off and it should not hang on CTRL-SHIFT-F12. Press Up Arrow to accelerate, Left/Right to steer and Down to break.

Yes you are correct, this does indeed work as you suggest.

Freddys Folly

Game works fine, but ctrl-shift-f12 locks up pi

This game is native and doesn't run on the JIT. I suspect you were sitting on the screen of text, where pressing the Left Arrow will bring your canon out. You'll need to reboot the Pi as you can't exit the game.

Yes that is the case, just tested again


Global Effect

See the page on Manual based protection, pressing SPACE will bypass it. This one is WIMP based, so don't use CTRL-SHIFT-F12 to terminate it.

Just tested this and yes that now works when pressing space

Guile

Game works fine, but ctrl-shift-f12 causes internal error: abort on data transfer at &FC1ABCA0 570

Another game that appears to be messing with the WIMP mode. I'm not sure why they're all causing a crash on your machine.

Could you please press F12 and type *WHERE after the crash, to see which ROM Module the crash is occurring in.

I have tried this again and it crashes every time on ctrl-shift-f12 with same error. I tried pressing f12 after pressing cancel on the error but I got a black screen. I then tried again but this time opened task window from the bottom right and typed WHERE and it showed the following
Address &FC1ABCA8 is at offset &00004948 in module 'BASIC'

[Idge]

Some more testing tonight, notes below

Heimdall
On the attribute section with the axe throwing, it's impossible to move the mouse cursor over to the right areas. I get that its supposed to move around a bit to make it harder to hit, but something doesnt seem right here.

Hostages
Music sounds wrong at the beginning. It seems to be missing several beats I think. I need to check my original to be sure, but doesn't sound right to me

Interdictor
Plays a very high pitched noise when starting and seems to crash to desktop when I pressed right mouse button

Interdictor 2
Also plays a very high pitched noise when starting

James Pond 2 - Robocod
The music is completely off on this version, but I think this is a known issue I believe

James Pond [SA]
Graphics seem very jerky and score bar seems to jitter when moving left and right

Kaptain Konflikt
I'm not sure if I'm doing something wrong here, but when playing game and selecting training I see no character on the screen but pressing enter shows something firing. If I press z and x it seems to move what would be the character as where I am firing from changes.

K.V
Says please insert K.V disk after pressing space to play game. Pressing enter locks up the pi

The Last Ninja
Starting the game now gives the below error
OS Claim 10 @ 0001A614 R12=00000000
OS Claim 10 @ 00D030CC R12=00D03488
ADFFS Exception: ADFF5016 Modifying hardware vectors

Leeds United
ADFFS Exception: ADFF5016 Modifying hardware vectors

Lemmings
When starting the game it seems to only say "go" instead of "Lets go"

Lemmings 2 [SA]
Game starts fine, but when starting the game on 1st level it says ok then hangs on a black screen

Logic Mania
All games work fine, but ctrl-shift-f12 does nothing at all in Gloop

[JonAbbott]

Heimdall
On the attribute section with the axe throwing, it's impossible to move the mouse cursor over to the right areas. I get that its supposed to move around a bit to make it harder to hit, but something doesnt seem right here.

Yes, it seems to be resetting the mouse position. I'll investigate

Hostages
Music sounds wrong at the beginning. It seems to be missing several beats I think. I need to check my original to be sure, but doesn't sound right to me

I've compared side by side with an A310 and it sounds near identical to me. I presume you're talking about the music on the opening screen when you first launch the game?

Interdictor
Plays a very high pitched noise when starting and seems to crash to desktop when I pressed right mouse button

Interdictor 2
Also plays a very high pitched noise when starting

I couldn't reproduce these. At what point did you press the right mouse button in Interdictor? I've tried clicking it at various points, but no crash.

James Pond 2 - Robocod
The music is completely off on this version, but I think this is a known issue I believe

Known issue. It also occurs on my A440/1. I've yet to pin down what's causing it.

James Pond [SA]
Graphics seem very jerky and score bar seems to jitter when moving left and right

I couldn't reproduce this. Is your Pi display configured for 50hz? Let me know what hdmi_group and hdmi_mode are set to in CONFIG/TXT so I can see if that's affecting the 50hz ticker. You could also quickly test Pacmania, as that should be buttery smooth and will highlight any display sync issues.

Kaptain Konflikt
I'm not sure if I'm doing something wrong here, but when playing game and selecting training I see no character on the screen but pressing enter shows something firing. If I press z and x it seems to move what would be the character as where I am firing from changes.

This game has a few bugs, which I've yet to fix. The main sprite sometimes isn't plotted and the music timing shifts.

K.V
Says please insert K.V disk after pressing space to play game. Pressing enter locks up the pi

I couldn't reproduce this. It doesn't normally ask for the disk to be inserted as the !Run mounts Disk 1 and it silently performs a protection check. Could you please retest directly after a power-cycle to confirm something else hasn't caused a knock on effect.c

EDIT: I have now reproduced this and will investigate.

The Last Ninja
Starting the game now gives the below error
OS Claim 10 @ 0001A614 R12=00000000
OS Claim 10 @ 00D030CC R12=00D03488
ADFFS Exception: ADFF5016 Modifying hardware vectors

I couldn't reproduce this. If you can reproduce it again, could you please let me know the address of the abort (the instruction with the * against it). Could you also confirm if its whilst loading, or when you click Start Game

Leeds United
ADFFS Exception: ADFF5016 Modifying hardware vectors

I'm seeing this as well, its a Null dereference bug. I'll see if I can figure out what the game code is supposed to be doing and fix it.

Lemmings
When starting the game it seems to only say "go" instead of "Lets go"

Lemmings 2 [SA]
Game starts fine, but when starting the game on 1st level it says ok then hangs on a black screen

I couldn't reproduce either of these issues. Could you please see if Lemmings 2 (non SA) has the same problem.

Logic Mania
All games work fine, but ctrl-shift-f12 does nothing at all in Gloop

Gloop runs natively, so CTRL-SHIFT-F12 is not going to work I'm afraid.

Guile

Game works fine, but ctrl-shift-f12 causes internal error: abort on data transfer at &FC1ABCA0 570

Another game that appears to be messing with the WIMP mode. I'm not sure why they're all causing a crash on your machine.

Could you please press F12 and type *WHERE after the crash, to see which ROM Module the crash is occurring in.

I have tried this again and it crashes every time on ctrl-shift-f12 with same error. I tried pressing f12 after pressing cancel on the error but I got a black screen. I then tried again but this time opened task window from the bottom right and typed WHERE and it showed the following
Address &FC1ABCA8 is at offset &00004948 in module 'BASIC'

Odd, why would BASIC be aborting? Do you have any Wimp tasks running that are BASIC apps?

[Idge]

Hostages
Music sounds wrong at the beginning. It seems to be missing several beats I think. I need to check my original to be sure, but doesn't sound right to me

I've compared side by side with an A310 and it sounds near identical to me. I presume you're talking about the music on the opening screen when you first launch the game?

Maybe it is just running slow. It is when the game starts and the car arrives and they get out. It just doesnt sound right to me, but I havent had a chance to test on original yet to compare.

Interdictor
Plays a very high pitched noise when starting and seems to crash to desktop when I pressed right mouse button

Interdictor 2
Also plays a very high pitched noise when starting

I couldn't reproduce these. At what point did you press the right mouse button in Interdictor? I've tried clicking it at various points, but no crash.

It was literally as it started, I didn't really know what I was doing, so clicked a few buttons including the right mouse button. I just tested again, pressing various mouse buttons, and I then got a big blue mouse pointer show on the screen and it then crashed.
EDIT: I have now updated my Pi to the latest stable Riscos rom and wiped it and set it all up from scratch and I no longer get the high pitched noise, however interdictor still crashed when I press the right mouse button a few times

James Pond [SA]
Graphics seem very jerky and score bar seems to jitter when moving left and right

I couldn't reproduce this. Is your Pi display configured for 50hz? Let me know what hdmi_group and hdmi_mode are set to in CONFIG/TXT so I can see if that's affecting the 50hz ticker. You could also quickly test Pacmania, as that should be buttery smooth and will highlight any display sync issues.

I have looked in my CONFIG/TXT file and I don't have either of these settings. The only setting I have related to hdmi is hdmi_pixel_freq_limt=250000000. I quickly ran Pacmania, and it is smooth, but I havent tested it for long.
EDIT: I have now updated my Pi to the latest stable Riscos rom and wiped it and set it all up from scratch and this no longer happens

K.V
Says please insert K.V disk after pressing space to play game. Pressing enter locks up the pi

I couldn't reproduce this. It doesn't normally ask for the disk to be inserted as the !Run mounts Disk 1 and it silently performs a protection check. Could you please retest directly after a power-cycle to confirm something else hasn't caused a knock on effect.

I just tried this and the game loaded this time, and then after a few seconds the disk prompt showed up again
EDIT: I have now updated my Pi to the latest stable Riscos rom and wiped it and set it all up from scratch and this seems to have some issues. It either loads the game and once you start playing it hangs the pi, or the game will load to the system tray but when you click it it makes the boot up noise and gives a black screen and you have to restart

The Last Ninja
Starting the game now gives the below error
OS Claim 10 @ 0001A614 R12=00000000
OS Claim 10 @ 00D030CC R12=00D03488
ADFFS Exception: ADFF5016 Modifying hardware vectors

I couldn't reproduce this. If you can reproduce it again, could you please let me know the address of the abort (the instruction with the * against it). Could you also confirm if its whilst loading, or when you click Start Game

Just tried again and it is when you click start game. It shows the following
0001942C E5801000 *STR R1,[R0, #0]
EDIT: I have now updated my Pi to the latest stable Riscos rom and wiped it and set it all up from scratch and this no longer happens

Lemmings 2 [SA]
Game starts fine, but when starting the game on 1st level it says ok then hangs on a black screen

EDIT: I have now updated my Pi to the latest stable Riscos rom and wiped it and set it all up from scratch and this is no longer happening

I couldn't reproduce either of these issues. Could you please see if Lemmings 2 (non SA) has the same problem.

Lemmings 2 (non SA) works fine

Guile

Game works fine, but ctrl-shift-f12 causes internal error: abort on data transfer at &FC1ABCA0 570

Another game that appears to be messing with the WIMP mode. I'm not sure why they're all causing a crash on your machine.

Could you please press F12 and type *WHERE after the crash, to see which ROM Module the crash is occurring in.

I have tried this again and it crashes every time on ctrl-shift-f12 with same error. I tried pressing f12 after pressing cancel on the error but I got a black screen. I then tried again but this time opened task window from the bottom right and typed WHERE and it showed the following
Address &FC1ABCA8 is at offset &00004948 in module 'BASIC'

Odd, why would BASIC be aborting? Do you have any Wimp tasks running that are BASIC apps?

I have now updated my pi to the latest stable image and set up everything from scratch again and this no longer gives the error